rusackas commented on PR #40563: URL: https://github.com/apache/superset/pull/40563#issuecomment-4775639413
@RoySerbi right direction, but `sharded-jest-tests (7)` is red on this PR's own suite — `cancel button closes modal without dispatching` fails at `SqlEditorTabHeader.test.tsx:209` because the input is still in the DOM after Cancel. Also `index.tsx`: the `Input` `onChange` does `e.target.value.trim()`, so spaces get stripped while typing and you can't enter a title like `my query`. Trim on confirm, not on change. Happy to help touch things up if you want help on this one (assuming I can push to the branch) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
