bito-code-review[bot] commented on PR #41311:
URL: https://github.com/apache/superset/pull/41311#issuecomment-4775793881
<!-- Bito Reply -->
The flagged issue is correct. Using `typeof value === 'number'` includes
`NaN` and `Infinity`, which can lead to invalid tooltip displays. Using
`Number.isFinite(value)` is the appropriate fix to ensure only valid numeric
values are processed.
To resolve this, update the guard definitions in
`superset-frontend/plugins/plugin-chart-echarts/src/utils/forecast.ts` as
follows:
**superset-frontend/plugins/plugin-chart-echarts/src/utils/forecast.ts**
```
const hasTrend = Number.isFinite(forecastTrend);
const hasLower = Number.isFinite(forecastLower);
const hasUpper = Number.isFinite(forecastUpper);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
