mistercrunch commented on a change in pull request #8289: react menu
URL:
https://github.com/apache/incubator-superset/pull/8289#discussion_r331752245
##########
File path: superset/views/base.py
##########
@@ -170,16 +170,61 @@ def json_response(self, obj, status=200):
mimetype="application/json",
)
+ def menu_data(self):
Review comment:
This may not be a real concern (and probably outside the scope of this PR),
but it seems like we're doing a fair amount of work here at each request. On
the FAB side we should make sure that this method doesn't lead to more than a
single database round trip, and I'm wondering whether we'd want to cache any of
this, probably not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
