rusackas commented on PR #41218: URL: https://github.com/apache/superset/pull/41218#issuecomment-4779373636
@aminghadersohi good catches — pushed a fix: - MEDIUM #1: added `all_columns` to the stored-query-context loop in `_collect_sortable_identifiers`, with a regression test that goes red without it. - MEDIUM #2: that test exercises the stored-qc branch in isolation (column present only in the query context, not `params_dict`). - LOW #3 / NIT #4: added the explanatory comments on the order-by union and the intentional `stored_values` asymmetry. Left the direction-bit and closure-docstring calls as-is per the earlier reasoning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
