rusackas opened a new pull request, #41343:
URL: https://github.com/apache/superset/pull/41343
### SUMMARY
Adopts #28754, original by @ericsong. Related to #20577.
The frontend's create-dashboard entry points navigate to `/dashboard/new`,
but the backend exposes the route as `/dashboard/new/` (`@expose("/new/")` in
`superset/views/dashboard/views.py`). Flask answers the slash-less URL with a
308 permanent redirect to the canonical trailing-slash version. In some
infrastructure setups (behind certain proxies/load balancers) that redirect
resolves to an invalid address and breaks the create-dashboard flow — see the
discussion in #20577. This change points every create-dashboard link/button
(welcome empty-state, right-hand menu, dashboard table, and dashboard list)
directly at `/dashboard/new/` so the browser hits the backend endpoint with no
308. The corresponding frontend tests are updated to expect the trailing-slash
URL. No behavioral change beyond the URL; rebased cleanly onto current `master`.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See the screenshots in the original PR #28754 (before: 308 redirect on
`/dashboard/new`; after: direct navigation to `/dashboard/new/`).
### TESTING INSTRUCTIONS
1. Hard-refresh to clear any cached redirect for `/dashboard/new`.
2. Create a new dashboard from the "+" menu, the welcome page empty state,
or the Dashboards list "Dashboard" button.
3. Confirm the network panel shows a direct request to `/dashboard/new/`
with no 308 redirect.
Unit tests: `cd superset-frontend && npm run test --
src/features/home/DashboardTable.test.tsx src/features/home/Menu.test.tsx
src/features/home/RightMenu.test.tsx`
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
---
Adopts #28754 (original author @ericsong), rebased onto current master.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
