rusackas commented on PR #40003: URL: https://github.com/apache/superset/pull/40003#issuecomment-4781726091
Pushed up docstrings for the two new methods to clear the CodeAnt notes. The two Copilot flags I think are false alarms... `BaseViz.__init__` already initializes `applied_filters`/`rejected_filters`, so there's no AttributeError risk, and the only non-string value in the metadata is `reason`, which is a `StrEnum`, so `json.dumps` is happy. LGTM otherwise :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
