costajohnt commented on PR #37458: URL: https://github.com/apache/superset/pull/37458#issuecomment-4781999152
Good catch, that was a copy-paste slip while I updated the markdown for the longer label, not intentional. I restored test_pivot_df_single_row_null_values so its expected tables use that case's own data again. The boy row is null, so it shows nan across the metrics and the totals, and girl keeps 118065 and 2588, so the null handling is actually being exercised again instead of the numbers from test_pivot_df_single_row_two_metrics. While I was in here I caught the branch up with master, since it had fallen a long way behind. That clears the earlier Playwright failures, which were coming from build-embedded-sdk not existing on the stale base rather than anything in this PR. I also kept the translation catalogs matching master so the regression bot stays quiet, since the rename adds no new fuzzy entries once CI re-extracts. Ran the pivot unit tests locally against the pinned toolchain and all 30 pass. Whenever you have a moment, would you mind approving the workflows so the full suite can run. They are sitting in the queue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
