rusackas commented on PR #40656: URL: https://github.com/apache/superset/pull/40656#issuecomment-4782287527
Nice small fix, but the new truncated-table message in index.tsx around line 348 fires purely on `data?.hasMore` without gating on readOnly, so in a disabled control (e.g. DatasourceEditor in non-edit mode) it tells people to refine a search they can't perform. Mind tucking it behind the same condition the Select and refresh label already use so it only shows when the control is actionable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
