rusackas commented on PR #41318:
URL: https://github.com/apache/superset/pull/41318#issuecomment-4782292568
The @types/d3-scale jump from 2.x to 4.x is a real type incompatibility that
needs a code fix before this can merge.
**What fails:** `lint-frontend` (TypeScript compiler) reports:
```
packages/superset-ui-core/test/color/CategoricalColorScale.test.ts(663,13):
error TS2322: Type 'CategoricalColorScale' is not assignable to type
'ScaleOrdinal<{ toString(): string; }, string, never>'
```
The `ScaleOrdinal` type signature changed between @types/d3-scale v2 and v4.
Someone needs to update `CategoricalColorScale` (or its tests) to match the new
generic signature. Not a lockfile issue — the bump actually causes a type error
that needs to be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
