gkneighb commented on PR #40399:
URL: https://github.com/apache/superset/pull/40399#issuecomment-4782690416
Pushed fixes for the CI failures from the master merge (`359eeb4d`):
- **Python-Unit**: reverted the `APP_NAME` read back to
`config.get("APP_NAME", "Superset")` — matches the branding pattern
`test_mcp_config.py` expects. ✅ all 27 config tests + 210 dashboard tests pass
locally.
- **pre-commit**: removed a now-unused `# type: ignore[call-arg]` and ran
`ruff format` on the changed files.
The other two reds are **not from this PR**:
- **Translations / babel-extract** fails on `msgcat: unrecognized option
'--sort-by-msgid'` — a runner gettext-version issue in `babel_update.sh`,
independent of these changes.
- **Python Presto/Hive** was a Docker-registry `connection reset` flake.
@aminghadersohi — could you **re-approve the workflow run** when you get a
chance? Python-Unit + pre-commit should be green now. 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
