hy144328 commented on PR #39782: URL: https://github.com/apache/superset/pull/39782#issuecomment-4782929150
> Approving CI, for starters. > > This seems to be landing the right fix: dttm.timestamp() interprets naive datetimes as local time, so epoch_s/epoch_ms output drifted with the server's TZ. Forcing UTC before timestamp() in dttm_sql_literal makes it deterministic, and replace() keeps it non-mutating. > > Approving, but the only nit is the title still says test: when this is really a fix(models): change. Happy to change the title if you'd like me to. @rusackas Thanks, I updated the title! By the way, GitHub Actions sent a message regarding translations. https://github.com/apache/superset/pull/39782#issuecomment-4782294202 But it disappeared after rebasing. :ok_hand: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
