rusackas commented on PR #24444: URL: https://github.com/apache/superset/pull/24444#issuecomment-4783148807
Looking again after the rebase. This is a nice addition, but `createLengthFormatter` has no test. Every other formatter factory in that dir has one, and codecov shows the new lines uncovered. Mind adding a `createLengthFormatter.test.ts` covering the three conversions? That'll help get it across the finish line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
