bito-code-review[bot] commented on code in PR #35825: URL: https://github.com/apache/superset/pull/35825#discussion_r3463723334
########## docs/admin_docs/configuration/async-queries-celery.mdx: ########## @@ -89,6 +89,12 @@ issues arise. Please clear your existing results cache store when upgrading an e - SQL Lab will _only run your queries asynchronously if_ you enable **Asynchronous Query Execution** in your database settings (Sources > Databases > Edit record). +- In order to use dedicated results backend, additional python libraries must be installed. These libraries can be installed using pip. + - [redis-py](https://pypi.org/project/redis/) for Redis. + - [pylibmc](https://pypi.org/project/pylibmc/) for memcached + - [s3werkzeugcache](https://pypi.python.org/pypi/s3werkzeugcache) for S3 Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Broken external link</b></div> <div id="fix"> The PyPI link for `s3werkzeugcache` uses the legacy `pypi.python.org` domain which triggers Cloudflare JavaScript challenges and is inaccessible. Update to `https://pypi.org/project/s3werkzeugcache/`. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- docs/admin_docs/configuration/async-queries-celery.mdx +++ docs/admin_docs/configuration/async-queries-celery.mdx @@ -92,7 +92,7 @@ - In order to use dedicated results backend, additional python libraries must be installed. These libraries can be installed using pip. - [redis-py](https://pypi.org/project/redis/) for Redis. - [pylibmc](https://pypi.org/project/pylibmc/) for memcached - - [s3werkzeugcache](https://pypi.python.org/pypi/s3werkzeugcache) for S3 + - [s3werkzeugcache](https://pypi.org/project/s3werkzeugcache/) for S3 - [minio-flask-cache](https://github.com/greggailly/minio-flask-cache) for MinIO or other S3 compatible service ``` </div> </details> </div> <small><i>Code Review Run #e31721</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
