codeant-ai-for-open-source[bot] commented on code in PR #40647:
URL: https://github.com/apache/superset/pull/40647#discussion_r3464131827
##########
tests/integration_tests/email_tests.py:
##########
@@ -37,9 +37,18 @@
class TestEmailSmtp(SupersetTestCase):
- def setUp(self):
+ SMTP_CONFIG_KEYS = ("SMTP_SSL", "SMTP_SSL_SERVER_AUTH", "SMTP_STARTTLS")
+
+ def setUp(self) -> None:
+ self._original_smtp_config = {
+ key: current_app.config[key] for key in self.SMTP_CONFIG_KEYS
+ }
current_app.config["SMTP_SSL"] = False
Review Comment:
**Suggestion:** Add an inline docstring to this newly added setup method
describing that it snapshots and overrides SMTP-related config keys for each
test run. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python method and it has no docstring. The custom rule
requires newly added Python functions and classes to include inline docstrings,
so this is a real violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=2d553b05af3e4eb2bc449d870a2bc0b4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=2d553b05af3e4eb2bc449d870a2bc0b4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/email_tests.py
**Line:** 42:46
**Comment:**
*Custom Rule: Add an inline docstring to this newly added setup method
describing that it snapshots and overrides SMTP-related config keys for each
test run.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40647&comment_hash=3a68caadba4bfccdbb24a7946bf2d9244d06143768935076cbfb4824375b59dd&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40647&comment_hash=3a68caadba4bfccdbb24a7946bf2d9244d06143768935076cbfb4824375b59dd&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
