codeant-ai-for-open-source[bot] commented on code in PR #32958:
URL: https://github.com/apache/superset/pull/32958#discussion_r3464348306
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/shared_dashboard_functions.ts:
##########
@@ -138,6 +138,7 @@ export function prepareDashboardFilters(
chart_customization_config: [],
timed_refresh_immune_slices: [],
expanded_slices: {},
+ expand_all_slices: false,
Review Comment:
**Suggestion:** Avoid extending Cypress E2E utilities and instead migrate
this new dashboard test metadata behavior into the Playwright E2E test helpers.
[custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This change is in a Cypress E2E test helper file (`cypress/e2e/...`) and
adds new test metadata behavior there. The custom rule explicitly says new or
updated E2E tests should use Playwright instead of Cypress, so the suggestion
correctly identifies a real rule violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d76b6edcd4184d13a2bf6b7cafa71da5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d76b6edcd4184d13a2bf6b7cafa71da5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/cypress-base/cypress/e2e/dashboard/shared_dashboard_functions.ts
**Line:** 141:141
**Comment:**
*Custom Rule: Avoid extending Cypress E2E utilities and instead migrate
this new dashboard test metadata behavior into the Playwright E2E test helpers.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F32958&comment_hash=1ae18d7aaca0dc4dbf662086f2d5a14876309fc7f28119206f61886cbb7008ed&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F32958&comment_hash=1ae18d7aaca0dc4dbf662086f2d5a14876309fc7f28119206f61886cbb7008ed&reaction=dislike'>👎</a>
##########
tests/integration_tests/import_export_tests.py:
##########
@@ -485,6 +485,56 @@ def test_import_override_dashboard_2_slices(self):
"native_filter_configuration": [],
} == json.loads(imported_dash.json_metadata)
+ def test_import_dashboard_expand_all_slices_false(self):
Review Comment:
**Suggestion:** Add explicit type hints for the test method signature,
including a `-> None` return annotation, so the newly added function is fully
typed. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python test method and it omits a return type
annotation. Under the stated rule, new Python code should be fully typed, so
the missing `-> None` is a real violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=2d852ab24a7e4df88e3dbd16d4aaf515&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=2d852ab24a7e4df88e3dbd16d4aaf515&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/import_export_tests.py
**Line:** 488:488
**Comment:**
*Custom Rule: Add explicit type hints for the test method signature,
including a `-> None` return annotation, so the newly added function is fully
typed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F32958&comment_hash=987ede6fe3efbd268f4be77fd83b98476579501e699d714b67f538c2f2e108f5&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F32958&comment_hash=987ede6fe3efbd268f4be77fd83b98476579501e699d714b67f538c2f2e108f5&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
