codeant-ai-for-open-source[bot] commented on code in PR #39900:
URL: https://github.com/apache/superset/pull/39900#discussion_r3465675574
##########
tests/unit_tests/mcp_service/explore/tool/test_generate_explore_link.py:
##########
@@ -73,6 +73,14 @@ def mock_auth():
yield mock_get_user
[email protected](autouse=True)
Review Comment:
**Suggestion:** Add explicit type annotations to this new fixture function,
including a return type for the yielded fixture value, so the new code is fully
typed. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python fixture function in the PR, and it has no
type annotations for parameters or return value. The rule requires new
Python code to be fully typed, so this is a real violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=039006772f4740538ed4513abc536fdf&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=039006772f4740538ed4513abc536fdf&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
tests/unit_tests/mcp_service/explore/tool/test_generate_explore_link.py
**Line:** 76:76
**Comment:**
*Custom Rule: Add explicit type annotations to this new fixture
function, including a return type for the yielded fixture value, so the new
code is fully typed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39900&comment_hash=f8de9ad0f0a58103681e67e61653c7edd4036447e0623cfa9885245628caddd9&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39900&comment_hash=f8de9ad0f0a58103681e67e61653c7edd4036447e0623cfa9885245628caddd9&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
