bito-code-review[bot] commented on PR #39350:
URL: https://github.com/apache/superset/pull/39350#issuecomment-4787455575
<!-- Bito Reply -->
The flagged issue is correct. In Helm templates, when a helper is called
with a dictionary, the dot `.` inside the helper refers to that dictionary, not
the original root context. Therefore, `.Release.Name` fails to resolve because
the dictionary does not contain a `Release` field. To fix this, you must access
the release name from the `root` object passed in the dictionary.
Here is the corrected implementation for
`helm/superset/templates/_helpers.tpl`:
```yaml
{{- define "superset.componentSelectorLabels" -}}
app.kubernetes.io/name: {{ include "superset.name" .root }}
app.kubernetes.io/instance: {{ .root.Release.Name }}
app.kubernetes.io/component: {{ .component }}
{{- end -}}
```
I have checked the PR diff and there are no other review comments in the
provided context. Would you like me to perform a more thorough check for
similar issues in other helpers within the same file?
**helm/superset/templates/_helpers.tpl**
```
{{- define "superset.componentSelectorLabels" -}}
app.kubernetes.io/name: {{ include "superset.name" .root }}
app.kubernetes.io/instance: {{ .root.Release.Name }}
app.kubernetes.io/component: {{ .component }}
{{- end -}}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
