amaannawab923 opened a new pull request, #41387:
URL: https://github.com/apache/superset/pull/41387

   ### SUMMARY
   
   On an interactive table with a metric in **Percentage Metrics** and **Show 
Summary** enabled, the summary/footer row showed `0.000%` for the percentage 
column while the regular rows were correct.
   
   The totals query was being built with an empty `post_processing` list. That 
dropped the `contribution` step that renames a percent-metric column from 
`metric` to `%metric`. The result was that the totals came back keyed under the 
original metric name, while the grid was reading the `%`-prefixed one — so it 
found nothing and rendered `0.000%`.
   
   The fix keeps the percent-metric `contribution` (rename) step on the totals 
query, while still dropping the time-comparison operator and ordering that 
aren't needed for an aggregate-only query.
   
   ### TESTING INSTRUCTIONS
   
   1. Open/create an interactive table on any dataset.
   2. Add a metric to **Metrics** and the same metric to **Percentage Metrics**.
   3. Enable **Show Summary** and update the chart.
   4. The percentage column in the summary row should show a real aggregated 
value instead of `0.000%`.
   
   Added a buildQuery test asserting the totals query keeps the 
contribution/rename op for percent metrics; the rest of the buildQuery suite 
still passes.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Changes UI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to