amaannawab923 opened a new pull request, #41389: URL: https://github.com/apache/superset/pull/41389
### SUMMARY This is a follow-up on reports that custom conditional formatting with **Use gradient** enabled rendered a flat color for the ranged operators (`< x <`, `≤ x ≤`, `≤ x <`, `< x ≤`) while single-bound operators worked fine. Digging into `getColorFunction`, the gradient computation is actually correct for all four ranged operators on current master — values across the defined range get distinct, proportional opacities, for both numeric and string-typed bounds (which is what form inputs produce). I couldn't reproduce a flat fill at the color-computation layer. Rather than change behavior that's already correct, I'm adding tests that lock this in so the ranged-operator gradients can't silently regress again. If a flat-color issue is still observable in practice, it's likely further up in the control/save path rather than in the color math, and this gives us a clear baseline to bisect from. ### TESTING INSTRUCTIONS `npm run test -- packages/superset-ui-chart-controls/test/utils/getColorFormatters.gradient.test.ts` The tests assert that each ranged operator produces three distinct opacities across the range (a real gradient), that string-typed bounds behave the same as numeric, and that turning gradient off yields a solid color. ### ADDITIONAL INFORMATION - [ ] Changes UI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
