ampil commented on PR #38168:
URL: https://github.com/apache/superset/pull/38168#issuecomment-4789540873

   In Superset 6.1.0, Flask is still `2.3.3`, while PR #38168 updates it to 
`3.1.3` on `master`.
   The 6.1.0 release was tagged on May 13, and the last commit from the PR was 
merged into master on Mar 4.
   
   When I try to manually upgrade Flask in 6.1.0 with the corresponding 
dependencies:
   
   ```
   flask==3.1.3
   flask-sqlalchemy==3.1.1
   flask-babel==4.0.0
   ```
   Superset fails to start (e.g. `ImportError` of `eagerload`). 
   ```
   Traceback (most recent call last):
     File "/app/.venv/bin/superset", line 4, in <module>
       from superset.cli.main import superset
     File "/app/superset/__init__.py", line 19, in <module>
       from superset.app import create_app  # noqa: F401
     File "/app/superset/app.py", line 39, in <module>
       from superset.extensions.local_extensions_watcher import (
     File "/app/superset/extensions/__init__.py", line 46, in <module>
       from superset.security.manager import SupersetSecurityManager
     File "/app/superset/security/__init__.py", line 17, in <module>
       from superset.security.manager import SupersetSecurityManager  # noqa: 
F401
     File "/app/superset/security/manager.py", line 52, in <module>
       from sqlalchemy.orm import eagerload
   ImportError: cannot import name 'eagerload' from 'sqlalchemy.orm' 
(/app/.venv/lib/python3.10/site-packages/sqlalchemy/orm/__init__.py)
   ```
   
   Tried the Docker image `apache/superset:6.1.0`.
   
   Is there a planned release that will include the Flask 3 update? Or some 
tips on how to upgrade to Flask 3.1.3?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to