eschutho opened a new pull request, #41393:
URL: https://github.com/apache/superset/pull/41393
### What was the deprecation warning?
`should_use_v2_api()` in `superset/utils/slack.py` logged a warning using a
triple-quoted string. Because the string was written inside an indented
`except` block, Python included the code-level indentation in the message —
each continuation line got 12 leading spaces. Production logs showed:
```
Your current Slack scopes are missing `channels:read`. Please add
this to your Slack app in order to continue using the v1 API.
Support
for the old Slack API will be removed in Superset version 6.0.0.
```
### What was changed?
Replaced the triple-quoted string with adjacent string literals so the
message renders as a single clean line:
```
Your current Slack scopes are missing `channels:read`. Please add this to
your Slack app in order to continue using the v1 API. Support for the old Slack
API will be removed in Superset version 6.0.0.
```
No logic change. Same words, no whitespace artifact.
### No-behavior-change note
This is a log message formatting fix only. `should_use_v2_api()` returns
exactly the same values in all paths. No imports added or removed.
### Test plan
- [ ] Confirm no pre-commit failures: `pre-commit run --files
superset/utils/slack.py`
- [ ] Confirm the message logs cleanly by checking the `logger.warning` call
manually or via existing Slack notification tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
