yousoph commented on PR #41106: URL: https://github.com/apache/superset/pull/41106#issuecomment-4792242286
Good call — addressed in a6c4a402. Replaced the manual field-by-field copying with `self._base_model.copy()` (which uses `ImportExportMixin.copy()` to copy all `export_fields`, with a fresh `id`/`uuid` since neither is in `export_fields`). Only four fields now need explicit override: `table_name`, `owners`, `database` (ORM relationship), and `is_sqllab_view`. Also simplified the columns/metrics loops to list comprehensions and added a null guard on `sql`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
