bito-code-review[bot] commented on code in PR #40746:
URL: https://github.com/apache/superset/pull/40746#discussion_r3472267262
##########
superset-frontend/src/features/tags/BulkTagModal.test.tsx:
##########
@@ -36,77 +36,80 @@ const mockedProps = {
resourceName: 'dashboard',
};
-afterEach(() => {
- fetchMock.clearHistory().removeRoutes();
- jest.clearAllMocks();
-});
-
-test('should render', () => {
- const { container } = render(<BulkTagModal {...mockedProps} />);
- expect(container).toBeInTheDocument();
-});
+// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from
describe blocks
+describe('BulkTagModal', () => {
Review Comment:
<!-- Bito Reply -->
The project's testing strategy, as documented in the repository, explicitly
advises using `test()` blocks instead of `describe()` blocks to avoid
unnecessary nesting and improve test isolation. Removing the `describe()` block
as suggested aligns the test file with these established project standards.
**superset-frontend/src/features/tags/BulkTagModal.test.tsx**
```
afterEach(() => {
fetchMock.clearHistory().removeRoutes();
jest.clearAllMocks();
});
test('should render', () => {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
