rusackas opened a new pull request, #41421:
URL: https://github.com/apache/superset/pull/41421
### SUMMARY
OAuth 2.0 support for Databricks, across AWS, Azure, and GCP.
Adopts #34619 (original work by @drummerwolli, who stepped away). I
re-applied their commits on current master and fixed the failing unit tests.
Authorship is preserved via co-author trailers.
The only real fix on top of the original work: `get_oauth2_token` was
overwriting the config's already-resolved `token_request_uri` with the AWS
template that still had an unsubstituted account-id placeholder, so the token
exchange POSTed to `.../accounts/{}/v1/token`. It now only falls back to the
AWS endpoint when no URI is configured. No behavioral change to the feature
otherwise.
### TESTING INSTRUCTIONS
- set up oauth config in superset_config.py for databricks as described in
the newly added docs
- install databricks dependencies
- run superset
- set up a DB connection to Databricks
- run a query with that connection and notice the OAuth login screen
Unit tests: `pytest tests/unit_tests/db_engine_specs/test_databricks.py
tests/unit_tests/db_engine_specs/test_databricks_multi_cloud.py`
### ADDITIONAL INFORMATION
- [x] Introduces new feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
