codeant-ai-for-open-source[bot] commented on code in PR #36880:
URL: https://github.com/apache/superset/pull/36880#discussion_r3474355352
##########
superset-frontend/cypress-base/cypress/e2e/database/modal.test.ts:
##########
@@ -63,56 +63,57 @@ describe('Add database', () => {
it('show error alerts on dynamic form for bad host', () => {
cy.get('.preferred > :nth-child(1)').click();
- cy.get('input[name="host"]').type('badhost', { force: true });
- cy.get('input[name="port"]').type('5432', { force: true });
- cy.get('input[name="username"]').type('testusername', { force: true });
- cy.get('input[name="database"]').type('testdb', { force: true });
- cy.get('input[name="password"]').type('testpass', { force: true });
-
- cy.get('body').click(0, 0);
-
+ cy.get('input[name="host"]').type('badhost', { force: true }).blur();
Review Comment:
**Suggestion:** Replace this newly added Cypress interaction with an
equivalent Playwright test step and migrate the updated E2E scenario to the
Playwright suite instead of extending Cypress coverage. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This file is a Cypress E2E spec under `cypress/e2e`, and the added line uses
Cypress APIs (`cy.get(...).type(...).blur()`).
The custom rule explicitly flags new or updated Cypress end-to-end tests and
requires Playwright instead, so this is a real violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7cf7ac50c53a4919ae1846d29b51dd5a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7cf7ac50c53a4919ae1846d29b51dd5a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/e2e/database/modal.test.ts
**Line:** 66:66
**Comment:**
*Custom Rule: Replace this newly added Cypress interaction with an
equivalent Playwright test step and migrate the updated E2E scenario to the
Playwright suite instead of extending Cypress coverage.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F36880&comment_hash=fa022aa7af31a12f33a7406be68846cf84f9f58d973415759d23ca730c4520f1&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F36880&comment_hash=fa022aa7af31a12f33a7406be68846cf84f9f58d973415759d23ca730c4520f1&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
