codeant-ai-for-open-source[bot] commented on code in PR #41285:
URL: https://github.com/apache/superset/pull/41285#discussion_r3475077098
##########
superset-frontend/src/extensions/ExtensionsStartup.tsx:
##########
@@ -67,9 +70,28 @@ const ExtensionsStartup: React.FC<{ children?:
React.ReactNode }> = ({
views,
};
+ // Load extensions without blocking the initial render (see #40915);
+ // surface any load failure as a warning toast instead of failing silently.
if (isFeatureEnabled(FeatureFlag.EnableExtensions)) {
- ExtensionsLoader.getInstance().initializeExtensions();
+ ExtensionsLoader.getInstance()
+ .initializeExtensions()
+ .then(() =>
+ supersetCore.utils.logging.info(
+ 'Extensions initialized successfully.',
+ ),
+ )
+ .catch(error => {
+ supersetCore.utils.logging.error(
+ 'Error setting up extensions:',
+ error,
+ );
+ dispatch(
+ addWarningToast(t('Extensions failed to load: %s', String(error))),
+ );
+ });
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not require per-extension extension load failures to reject or block
initialization; log individual failures and continue loading the remaining
extensions. Reserve the warning toast for top-level API fetch failures.
**Applied to:**
- `superset-frontend/src/extensions/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
superset-frontend/src/core/sqlLab/models.ts:
##########
@@ -62,6 +65,7 @@ export class Tab implements sqlLabType.Tab {
this.schema = schema;
this.editorGetter = editorGetter;
this.panels = panels;
+ this.backendId = backendId;
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not derive `backendId` from `id` in `Tab`; it should only mirror
`tabViewId`. If bootstrapped tabs need a backend identifier, populate
`tabViewId` during bootstrap instead of overloading `backendId` here.
**Applied to:**
- `superset-frontend/src/core/sqlLab/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
