codeant-ai-for-open-source[bot] commented on code in PR #40812:
URL: https://github.com/apache/superset/pull/40812#discussion_r3476051061
##########
tests/unit_tests/pandas_postprocessing/test_pivot.py:
##########
@@ -40,6 +40,30 @@ def test_pivot_without_columns():
assert df["idx_nulls"].sum() == 1050
+def test_pivot_with_empty_columns_list():
Review Comment:
**Suggestion:** Add an explicit return type hint to this newly added test
function (for example, annotating it as returning `None`) to satisfy the
requirement that new Python functions are fully typed. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python test function, and it lacks a return type hint.
The custom rule requires new Python functions to be fully typed, so omitting
`-> None` is a real violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=33f3f4608a304b60b95ce3a3ba65e897&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=33f3f4608a304b60b95ce3a3ba65e897&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/pandas_postprocessing/test_pivot.py
**Line:** 43:43
**Comment:**
*Custom Rule: Add an explicit return type hint to this newly added test
function (for example, annotating it as returning `None`) to satisfy the
requirement that new Python functions are fully typed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40812&comment_hash=d206f1379084b2aa9df84601b3e03ae0e605023a113ae53a14d68faa178ab7c0&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40812&comment_hash=d206f1379084b2aa9df84601b3e03ae0e605023a113ae53a14d68faa178ab7c0&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
