rusackas commented on code in PR #41400:
URL: https://github.com/apache/superset/pull/41400#discussion_r3476408677
##########
superset-frontend/plugins/preset-chart-deckgl/src/utils.test.ts:
##########
@@ -488,3 +492,40 @@ describe('getBreakPoints', () => {
});
});
});
+
+describe('getBuckets', () => {
+ const accessor = (d: any) => d.value;
+
+ const buildFeatures = (values: number[]) => values.map(value => ({ value }));
+
+ test('produces non-overlapping bucket labels (no shared endpoints)', () => {
+ // With break points [1, 81, 212, 369] the legacy behavior produced
+ // "1 - 81", "81 - 212", "212 - 369" where each interior breakpoint
+ // (81, 212) appeared in two adjacent labels, reading as overlapping
+ // ranges. Labels should instead form a clean, non-overlapping partition.
+ const fd: any = {
Review Comment:
Typed the fixture as `QueryFormData & BucketsWithColorScale` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
