codeant-ai-for-open-source[bot] commented on code in PR #40397:
URL: https://github.com/apache/superset/pull/40397#discussion_r3476453760
##########
tests/unit_tests/mcp_service/chart/tool/test_list_charts.py:
##########
@@ -184,6 +184,29 @@ def test_filter_validation(self):
with pytest.raises(ValueError, match="Field required"):
ChartFilter(col="slice_name") # Missing opr and value
+ def test_dashboards_filter_accepted(self):
Review Comment:
**Suggestion:** Add full type hints to this newly added test method,
including an explicit return type, to satisfy the rule that new Python code
must be fully typed. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python test method, and it lacks both parameter
annotations and an explicit return type.
The rule requires new Python code to be fully typed, so this is a real
violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3f424e8f59bc47ca89fd2eca08043c1a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3f424e8f59bc47ca89fd2eca08043c1a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/mcp_service/chart/tool/test_list_charts.py
**Line:** 187:187
**Comment:**
*Custom Rule: Add full type hints to this newly added test method,
including an explicit return type, to satisfy the rule that new Python code
must be fully typed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40397&comment_hash=95c9ecab759578ca7adc8fe831fc0730c058dc04af5abc30ba1b5b01e63bcb5b&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40397&comment_hash=95c9ecab759578ca7adc8fe831fc0730c058dc04af5abc30ba1b5b01e63bcb5b&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
