rusackas commented on PR #39461: URL: https://github.com/apache/superset/pull/39461#issuecomment-4804785321
Thanks @sadpandajoe and @aminghadersohi - knocked out the regressions you both flagged: The owner picker is the real one - restored `OwnerSelectLabel` + `OWNER_OPTION_FILTER_PROPS` (and the two extra-field props), so emails show under the name and email search works again in the dataset editor. Also restored the self-scrolling flex chain on the datasource tabs, split the `AdhocFilterEditPopover` mount effect so it stops rebinding/re-fetching on every `propsAdhocFilter` change, and fixed the `id === 0` key guard in `CollectionTable`. Left one open on the `CollectionTable` sort - it mirrors master (the class also sorts from props), so I asked inline whether to fold that behavior change in here or split it. Running CI 🤞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
