sha174n commented on code in PR #41426:
URL: https://github.com/apache/superset/pull/41426#discussion_r3478901261
##########
tests/unit_tests/models/test_validate_expression.py:
##########
@@ -152,6 +155,36 @@ def test_validate_empty_expression(self, mock_execute):
# The actual error message will come from the exception
assert "empty" in result["errors"][0]["message"].lower()
+ @patch("superset.models.helpers.is_feature_enabled", return_value=False)
+
@patch("superset.connectors.sqla.models.SqlaTable._execute_validation_query")
Review Comment:
Added full type hints in f40701cf40; the two tests are now one parametrized
method `test_validate_expression_rejects_disallowed_constructs(self,
mock_execute: MagicMock, mock_ff: MagicMock, expression: str, expected_message:
str) -> None`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
