rusackas commented on PR #39461:
URL: https://github.com/apache/superset/pull/39461#issuecomment-4810296820
@EnxDev thanks for the thorough pass - that surfaced a few more the
conversion dropped. Pushed fixes for the rest of them:
`AdhocMetricEditPopover` lost both the saved-metric `localeCompare` sort and
the `compatibleMetrics` disabled gate when the redux wrapper got deleted -
re-added the gate via `useSelector` in the FC. Same file, `refreshAceEditor`
was calling `.editor?.resize?.()` (a no-op) instead of `resize()` on the
`EditorHandle`; fixed.
`AdhocMetricPopoverTrigger` was guarding the label overwrite on
`currentLabel` instead of `savedMetricLabel`, so a custom-labeled adhoc metric
lost its label on column change - guard's back on `savedMetricLabel`.
`AdhocFilterEditPopover` now hides the Custom SQL tab for `semantic_view`
again, and `DatasourceEditor` re-syncs columns on a physical table change.
And the `ControlHeader {...this.props}` narrowing in
`AdhocFilterControl`/`FixedOrMetricControl`/`SpatialControl` - those now
forward the rest of the props so validation styling and the tooltips come back.
Left the lower-severity lifecycle nits (mount-effect double-fires, the
`[datasource]` keying, TextControl flush-on-unmount) for a closer look - some
of those are arguably intended for the FC, so I don't want to swing at them
blind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
