aminghadersohi commented on PR #40958: URL: https://github.com/apache/superset/pull/40958#issuecomment-4810907194
Addressed in 9fe80bb — the 4 additional suggestions from Bito run #db9f95: 1. **`permission_tag_map` / TOOL_OBJECT_TYPE_MAP** — added `"remove_chart_from_dashboard": "dashboard"` to `FieldPermissionsMiddleware.TOOL_OBJECT_TYPE_MAP` in `middleware.py`, matching the pattern for `add_chart_to_existing_dashboard`. 2. **tool-search-optimization.md mutate list** — added `remove_chart_from_dashboard` to the mutate tools row in the docs. 3. **Consistent exception handler response** — added `removed_layout_keys=[]` and `permission_denied=False` to the outer `except` handler's `RemoveChartFromDashboardResponse`. 4. **Fallback DashboardInfo missing fields** — added `created_on` and `changed_on` to the re-fetch-fallback `DashboardInfo` construction so it matches the success path shape. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
