bito-code-review[bot] commented on code in PR #40000:
URL: https://github.com/apache/superset/pull/40000#discussion_r3483350581
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx:
##########
@@ -143,9 +114,6 @@ const FilterValue: FC<FilterValueProps> = ({
}) => {
const { id, targets, filterType } = filter;
const isCustomization = isChartCustomization(filter);
- const allowedTimeGrains = isCustomization
- ? undefined
- : (filter as TimeGrainFilterConfig).time_grains;
const adhocFilters = isCustomization ? undefined : filter.adhoc_filters;
const timeRange = isCustomization ? undefined : filter.time_range;
const granularitySqla = isCustomization ? undefined :
filter.granularity_sqla;
Review Comment:
<!-- Bito Reply -->
Thank you for the clarification. Since the filtering logic has been moved to
the time grain plugins themselves, the configuration is indeed being utilized
as intended in the new architecture. I have noted this as a false positive and
will avoid similar suggestions for this code path in future reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
