rusackas commented on PR #40493: URL: https://github.com/apache/superset/pull/40493#issuecomment-4814392761
Don't worry about Copilot here, I'm out of credits on it, but it's not my/our only way to review ;). We can probably ship this once it's rebased. I'll just do that now for ya :) Verified that chart results write through `data_cache` via `set_query_result(region=CacheRegion.DATA)`, and that's the same path that records the `CacheKey` row, so invalidating against the default `cache` was hitting the wrong backend. Fix is correct and the regression test is solid. Approving after the rebase... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
