rusackas commented on PR #34592: URL: https://github.com/apache/superset/pull/34592#issuecomment-4815437589
@rafal-celinski first off, thank you for this... it's what got the ball rolling on actually fixing #25747 properly. Your `buildGroupbyCombinations` (and its tests) got adopted pretty much as-is, and the approach grew from there into a fuller fix covering both the pivot table and the regular table chart, plus a `GROUPING SETS` path so it's one query instead of N where the engine supports it. I've written it up as a SIP (#41463) with a working POC in #41184. Rather than have you keep fighting the rebase conflicts here, I think the cleanest path is to carry it forward there and close this one out once that lands, with credit to you. Would love your eyes on either if you have the time. Sound ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
