rusackas commented on PR #36606: URL: https://github.com/apache/superset/pull/36606#issuecomment-4815521865
@nitishagar thanks for this. Heads up that there's a bigger effort underway to rework pivot totals (SIP #41463, with a POC in #41184), and one of the things it does is drop the per-table "Aggregation function" control entirely, since each metric now gets computed at its own grouping level rather than via a single client-side aggregator. That removes the `aggregatorName` these labels lean on, so "Total (Sum)" / "Aggregate (Sum)" collapse down to just "Total" / "Subtotal". So I suspect this one ends up superseded once that lands... though the underlying naming question in #35089 (is "Subtotal" really the clearest word for a non-additive metric?) is still very much worth settling, just probably over there in the new world. Would you agree? Don't want to close it out from under you if you're seeing it differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
