bito-code-review[bot] commented on code in PR #41478:
URL: https://github.com/apache/superset/pull/41478#discussion_r3485522659
##########
pyproject.toml:
##########
@@ -108,7 +108,7 @@ dependencies = [
"simplejson>=4.1.1",
"slack_sdk>=3.19.0, <4",
"sqlalchemy>=1.4, <2",
- "sqlalchemy-utils>=0.38.0, <0.43", # expanding lowerbound to work with
pydoris
+ "sqlalchemy-utils>=0.42.1, <0.43", # expanding lowerbound to work with
pydoris
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Inconsistent dependency bounds</b></div>
<div id="fix">
The main pyproject.toml now requires `>=0.42.1` for pydoris compatibility,
but `superset-core/pyproject.toml` line 50 still has `>=0.38.0`. This
inconsistency could cause pip to resolve different versions depending on which
package is installed first, potentially leading to pydoris incompatibility.
Keep both files in sync.
</div>
</div>
<small><i>Code Review Run #130359</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
