rusackas opened a new pull request, #41488:
URL: https://github.com/apache/superset/pull/41488
Follow-up to #40435.
That PR converted most ALL CAPS button labels to sentence case but missed
the time range filter popover in the ListView filters (different component from
the explore `DateFilterLabel` that #40435 did fix). This finishes the job.
### Changes
- `components/ListView/Filters/TimeRange.tsx`: `CANCEL` -> `Cancel`, `APPLY`
-> `Apply` (matches the sentence-case convention used everywhere else for these
buttons).
- `components/Chart/chartAction.ts`: dropped a redundant `QueryData &` from
a type assertion. The `response` is already inferred as `QueryData`, so
re-asserting it in the intersection was redundant; `response as { warning?:
string | null }` is enough.
The existing `TimeRange.test.tsx` queries these buttons with
case-insensitive regex (`/cancel/i`, `/apply/i`), so no test changes are needed.
### Test plan
- [ ] Time range filter popover (list views): verify Cancel/Apply buttons
render correctly
- [ ] `jest` passes on `TimeRange.test.tsx`
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
