rusackas commented on PR #38791: URL: https://github.com/apache/superset/pull/38791#issuecomment-4825137381
@hemasrishalini apologies, I think I accidentally caused some duplicated effort here. I stumbled onto a Devin-authored fix for #38789 and adopted it over in #41398 (a minimal version that just suppresses the outline on the wrapper, plus a regression test) without realizing you already had this going... sorry about that. The good news is your PR does quite a bit more than the bug fix, so I don't think they're really dupes. The move to `NoAnimationDropdown` + `Menu` and tearing out the manual `indicatorRefs`/`handleKeyDown` nav is a real modernization that stands on its own. I'm tempted to land the small fix to close #38789 out, and keep this one scoped to the `Menu` refactor (retitled/rebased) so the cleanup still lands... but totally your call. Happy to go the other way if you'd rather carry the whole thing here. Holler if you want a hand with the rebase either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
