rusackas commented on PR #39226: URL: https://github.com/apache/superset/pull/39226#issuecomment-4825338923
@michael-s-molina thanks for the patience, finally circled back on this. Rebased onto current `master` (which had since moved the `window.superset` types out into `Namespaces` and added a couple namespaces), and squashed the add-then-revert palette churn down to a single commit. Took your last two notes: dropped the `@apache-superset/core/colors` subpath and its re-export shim entirely since nothing imports it yet, so the API only lives under `@apache-superset/core/theme` now. And the host side follows the `src/core` pattern instead of the inline block, there's a `src/core/theme/colors.ts` that wires up `getCategoricalSchemeRegistry()`, registered as a `theme` namespace like `authentication`/`navigation`. Palette data still stays in `@superset-ui/core`. Running CI 🤞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
