bito-code-review[bot] commented on PR #41503:
URL: https://github.com/apache/superset/pull/41503#issuecomment-4825741022
<!-- Bito Reply -->
The flagged issue is correct. Binding `aria-label` directly to `label`
causes screen readers to announce technical identifiers (like
`copy-col-${data.name}`) instead of human-readable text. To resolve this, you
should prioritize the `tooltip` prop for the accessible name, as it is
typically localized and descriptive.
Here is the corrected implementation for
`superset-frontend/packages/superset-ui-core/src/components/ActionButton/index.tsx`:
```tsx
<span
role="button"
tabIndex={0}
aria-label={tooltip || label}
css={css`
cursor: pointer;
```
There are no other comments in this PR to address. Would you like me to
check for any other potential accessibility improvements in this file?
**superset-frontend/packages/superset-ui-core/src/components/ActionButton/index.tsx**
```
<span
role="button"
tabIndex={0}
aria-label={tooltip || label}
css={css`
cursor: pointer;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
