rusackas commented on PR #41426: URL: https://github.com/apache/superset/pull/41426#issuecomment-4827255660
Thanks @sha174n, the change itself looks good to me, routing `validate_expression` through `validate_stored_expression` so the same parser policy applies is a nice consistency win, and the tests asserting it rejects before execution are solid. One thing though... the title, description, and branch name all describe an RLS `get_predicates_for_table` null-schema fix, but the actual diff is the expression-validation change. Mind rewriting the description (and dropping the `row-level-security` label) so it matches what's here? Otherwise the squash commit and history end up misleading. Also needs a rebase, GitHub shows conflicts on `master`... holler if you want a hand with that. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
