codeant-ai-for-open-source[bot] commented on code in PR #39922: URL: https://github.com/apache/superset/pull/39922#discussion_r3488663141
########## superset/mcp_service/chart/plugins/__init__.py: ########## @@ -0,0 +1,58 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Chart type plugins package. + +Importing this module registers all built-in chart type plugins in the global +registry. This module is imported by app.py at startup. + +To add a new chart type: +1. Create ``superset/mcp_service/chart/plugins/{chart_type}.py`` +2. Implement a class extending ``BaseChartPlugin`` +3. Import and register it here +""" + +from superset.mcp_service.chart.plugins.big_number import BigNumberChartPlugin +from superset.mcp_service.chart.plugins.handlebars import HandlebarsChartPlugin +from superset.mcp_service.chart.plugins.mixed_timeseries import ( + MixedTimeseriesChartPlugin, +) +from superset.mcp_service.chart.plugins.pie import PieChartPlugin +from superset.mcp_service.chart.plugins.pivot_table import PivotTableChartPlugin +from superset.mcp_service.chart.plugins.table import TableChartPlugin +from superset.mcp_service.chart.plugins.xy import XYChartPlugin +from superset.mcp_service.chart.registry import register + +# Register all built-in chart type plugins +register(XYChartPlugin()) +register(TableChartPlugin()) +register(PieChartPlugin()) +register(PivotTableChartPlugin()) +register(MixedTimeseriesChartPlugin()) +register(HandlebarsChartPlugin()) +register(BigNumberChartPlugin()) + +__all__ = [ + "BigNumberChartPlugin", + "HandlebarsChartPlugin", + "MixedTimeseriesChartPlugin", + "PieChartPlugin", + "PivotTableChartPlugin", + "TableChartPlugin", + "XYChartPlugin", +] Review Comment: **Suggestion:** Add an explicit type annotation for the exported module variable so the new Python code complies with the type-hints requirement. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> The new Python module defines a module-level variable `__all__` without a type annotation. Under the stated rule, relevant variables that can be annotated should include type hints, so this is a real violation. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=fa563ce2fb0d4baf8314e2467897ab5f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=fa563ce2fb0d4baf8314e2467897ab5f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/mcp_service/chart/plugins/__init__.py **Line:** 50:58 **Comment:** *Custom Rule: Add an explicit type annotation for the exported module variable so the new Python code complies with the type-hints requirement. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39922&comment_hash=5373b1f430320721c47c7975976838b1e72db33067b1da9260bc4e4d16f47ca8&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39922&comment_hash=5373b1f430320721c47c7975976838b1e72db33067b1da9260bc4e4d16f47ca8&reaction=dislike'>👎</a> ########## superset/mcp_service/chart/plugins/big_number.py: ########## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Big number chart type plugin.""" + +from __future__ import annotations + +from collections.abc import Mapping +from typing import Any, ClassVar + +from superset.mcp_service.chart.chart_utils import ( + _big_number_chart_what, + _summarize_filters, + is_column_truly_temporal, + map_big_number_config, +) +from superset.mcp_service.chart.plugin import BaseChartPlugin +from superset.mcp_service.chart.schemas import BigNumberChartConfig, ColumnRef +from superset.mcp_service.chart.validation.dataset_validator import DatasetValidator +from superset.mcp_service.common.error_schemas import ChartGenerationError + + +class BigNumberChartPlugin(BaseChartPlugin): + """Plugin for big_number chart type.""" + + chart_type = "big_number" + display_name = "Big Number" Review Comment: **Suggestion:** Add explicit type annotations for these class-level variables (for example using `ClassVar[str]`) to satisfy the type-hint requirement for relevant variables. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> The file introduces new class-level variables `chart_type` and `display_name` without type annotations, and these can be annotated as `str`. This matches the Python type-hint rule for relevant variables. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=cd8f528c92f440518be4c4ab840dd0c7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=cd8f528c92f440518be4c4ab840dd0c7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/mcp_service/chart/plugins/big_number.py **Line:** 40:41 **Comment:** *Custom Rule: Add explicit type annotations for these class-level variables (for example using `ClassVar[str]`) to satisfy the type-hint requirement for relevant variables. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39922&comment_hash=12539b2c92f79dec79d62377c064bd43a3547f01d28a9abab5d31b3ecab9c389&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39922&comment_hash=12539b2c92f79dec79d62377c064bd43a3547f01d28a9abab5d31b3ecab9c389&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
