rusackas commented on PR #41281: URL: https://github.com/apache/superset/pull/41281#issuecomment-4827913847
@GagandeepSingh20 I think the approach looks OK... I'll take another review pass at it when CI is green, but right now, it needs a rebase to fix the flagged translation problem, and you'll need to get pre-commit to pass. Superset uses Git pre-commit hooks courtesy of [pre-commit](https://pre-commit.com/). To install run the following: ``` pip3 install -r requirements/development.txt pre-commit install ``` A series of checks will now run when you make a git commit. Alternatively it is possible to run pre-commit by running pre-commit manually: ``` pre-commit run --all-files ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
