rusackas commented on issue #41498: URL: https://github.com/apache/superset/issues/41498#issuecomment-4828050003
Thanks @krmmkr, the problems here are real, the multi-date case especially (Order Date global, Shipping Date local) is something the native filter bar genuinely struggles with (many of us want an improvement there), and "let me put a filter wherever I want on the canvas" comes up a lot... I have use cases for it to on my own dashboards. My hesitation is the approach rather than the goal. Filters-as-charts is essentially what the old Filter Box viz was, and we spent a fair bit of effort deprecating and removing it in favor of native filters. Mostly because the state lived in the chart and didn't compose with the unified filter system. So my first question is: what's different this time? It'd help to spell out why we wouldn't just be reintroducing the thing we paid to remove. The part I'd want designed up front is how these coexist with native filters. Native filters are intended to be the one source of truth for filter state, plus permalinks, defaults, dependent filters, scoping, clear-all... how does a chart-based filter participate in all that, rather than becoming a second, parallel filtering model on the same dashboard? We definitely want this all to be cohesive. The link to #40809 also raises an eyebrow. If these plugins generate cross-filter relationships complex enough to need a whole new management UI, that feels like solving complexity by adding complexity. And leaning on cross-filter emit as the transport for a deliberate filter control is a bit of a stretch/overloading from what emit was built for. I guess the bigger question: would we get most of this by letting native filters live on the canvas with local scoping, instead of standing up parallel plugins? That's more or less what many of us have been talking about doing sooner or later. Would love to see why that path was set aside. CC @michael-s-molina / @geido, who've lived in the native filter code the most, and will likely have some PTSD from Filter Boxes reading all this :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
