codeant-ai-for-open-source[bot] commented on code in PR #40912:
URL: https://github.com/apache/superset/pull/40912#discussion_r3488877331
##########
superset-frontend/src/hooks/apiResources/apiResources.test.ts:
##########
@@ -97,6 +97,48 @@ describe('apiResource hooks', () => {
error: fakeError,
});
});
+
+ test('skips the fetch and stays loading when skip is true', async () => {
+ const fetchMock = jest.fn().mockResolvedValue(fakeApiResult);
+ (makeApi as any).mockReturnValue(fetchMock);
Review Comment:
**Suggestion:** Replace the `any` cast on `makeApi` with a concrete mocked
function type (for example, a typed Jest mock signature) before calling
`mockReturnValue`. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The added TypeScript test code uses an `any` cast on `makeApi`, which
directly violates the no-any-types rule. Replacing it with a concrete Jest mock
type is the correct fix.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d0910d87c9574afc8324d100dece2aaf&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d0910d87c9574afc8324d100dece2aaf&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/hooks/apiResources/apiResources.test.ts
**Line:** 103:103
**Comment:**
*Custom Rule: Replace the `any` cast on `makeApi` with a concrete
mocked function type (for example, a typed Jest mock signature) before calling
`mockReturnValue`.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40912&comment_hash=ebdc5c6d6f34da9228ce55e05c8b912cd19b7f5a2f4463adf23ce344d508fab6&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40912&comment_hash=ebdc5c6d6f34da9228ce55e05c8b912cd19b7f5a2f4463adf23ce344d508fab6&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
