bito-code-review[bot] commented on PR #41513: URL: https://github.com/apache/superset/pull/41513#issuecomment-4829450425
<!-- Bito Reply --> The suggestion to add an explicit type annotation to the backwards-compatibility alias is correct and improves type safety. You can resolve this by updating the assignment in `superset/db_engine_specs/databend.py` to include the type hint `type[DatabendEngineSpec]`. Would you like me to implement this fix for you? I can also check the rest of the PR for similar issues if you would like me to proceed with a full review. **superset/db_engine_specs/databend.py** ``` DatabendConnectEngineSpec: type[DatabendEngineSpec] = DatabendEngineSpec ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
