bito-code-review[bot] commented on code in PR #41527:
URL: https://github.com/apache/superset/pull/41527#discussion_r3490213705
##########
superset-frontend/src/explore/components/controls/DateFilterControl/tests/utils.test.ts:
##########
@@ -185,3 +188,18 @@ describe('Custom TimeRange', () => {
});
});
});
+
+test('guessFrame returns Common for sub-hour presets', () => {
+ expect(guessFrame('Last 5 minutes')).toBe('Common');
+ expect(guessFrame('Last 15 minutes')).toBe('Common');
+ expect(guessFrame('Last 30 minutes')).toBe('Common');
+ expect(guessFrame('Last 1 hour')).toBe('Common');
+});
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incomplete test coverage</b></div>
<div id="fix">
Test assertions verify `guessFrame` returns `'Common'` but don't validate
other FrameType values (`'Calendar'`, `'Current'`, `'Custom'`, `'Advanced'`,
`'No filter'`). Per BITO.md rule 6262, tests should verify the actual business
logic comprehensively. Consider adding cases like `guessFrame('previous
calendar week')` → `'Calendar'` or `guessFrame('Current day')` → `'Current'`.
</div>
</div>
<small><i>Code Review Run #f83bec</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
