matebenyovszky commented on PR #39171:
URL: https://github.com/apache/superset/pull/39171#issuecomment-4833488953
Hey @michael-s-molina — great to see the progress! Almost everything is
green now. 🎉
The **only remaining CI failure is `pre-commit`** — specifically `prettier`
auto-formatting on `ephemeralState.ts`. The fix is trivial — two `set` method
signatures need line-breaking because they exceed the line width:
```diff
--- a/superset-frontend/src/core/storage/ephemeralState.ts
+++ b/superset-frontend/src/core/storage/ephemeralState.ts
@@ line 50 and 67
- set: async (key: string, value: JsonValue, options:
EphemeralSetOptions) => {
+ set: async (
+ key: string,
+ value: JsonValue,
+ options: EphemeralSetOptions,
+ ) => {
```
**Quick fix** — from `superset-frontend/`:
```bash
npx prettier --write src/core/storage/ephemeralState.ts
git add -u && git commit --trailer "Co-authored-by: Cursor
<[email protected]>" -m "Fix prettier formatting" && git push
```
Once that's committed, all CI should be green and this can be marked **Ready
for Review**! 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
